The main flaw is that cp doesn't copy resource forks. I would use sudo ditto -rsrc /Users/olduser/ /Users/newuser/ the other advantage of ditto is that it automatically copies directories.
EDIT: the above code should be written across a single line with a single space after ditto, -rsrc...